fix input device filtering and descriptor serialization#39
Open
fix input device filtering and descriptor serialization#39
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Linux audio device selection issues in apps/desktop/src-tauri/src/platform/audio.rs by making three changes: (1) added #[serde(rename_all = "camelCase")] to InputDeviceDescriptor struct to fix a serialization mismatch where Rust was sending is_default but TypeScript expected isDefault, (2) changed device name matching from exact string equality to bidirectional substring matching (label.contains(pref) || pref.contains(label)) so that saved device preferences like "USB Microphone" still match when ALSA/PulseAudio returns names with hardware suffixes like "USB Microphone (hw:1,0)", and (3) added Linux-specific virtual device keywords ("monitor of", "samplerate", "null") to the LOW_QUALITY_INPUT_KEYWORDS filter to prevent the app from trying to record from PulseAudio monitor devices and ALSA virtual converters that don't provide actual microphone input, which was causing timeouts in automatic mode.
Closes #36