Edge to Edge handling #766
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- package in AndroidManifest.xml is deprecated. Declare namespace in build.gradle instead. - R class package changed because of namespace name changed to globally unique name. - replace deprecated classifier to archiveClassifier
- `android:exported="true"` is required above Android 12
- Add kotlin android plugin to suppress ` Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found` error.
Aniokrait
commented
Aug 17, 2025
Comment on lines
+12
to
+14
| plugins { | ||
| id 'org.jetbrains.kotlin.android' version '1.8.0' apply false | ||
| } |
There was a problem hiding this comment.
Add these lines to suppress Duplicate class kotlin.collections.jdk8.CollectionsJDK8Kt found error.
| @@ -10,7 +9,8 @@ | |||
| <activity | |||
| android:name=".MainActivity" | |||
| android:label="@string/app_name" | |||
| android:theme="@style/AppTheme"> | |||
| android:theme="@style/AppTheme" | |||
| android:exported="true"> | |||
There was a problem hiding this comment.
Starting Android 12, exproted="true" is needed explicitly.
| @@ -14,7 +14,7 @@ | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| --> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.google.zxing.client.android"> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | |||
There was a problem hiding this comment.
package in AndroidManifest is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Starting with target SDK 35, edge-to-edge has been enabled by default. The prompt message shown in the capture preview was being cut off because CaptureActivity didn't properly handle edge-to-edge display.
What Changed
image
I have tested this on API 24 and API 35 emulators and it works as expected. However, I wasn't able to confirm functionality below API 24 since I couldn't install lower API level emulators.