feat: integrate dynamic task input into persona workflow#12
feat: integrate dynamic task input into persona workflow#12joy7758 merged 2 commits intopersona-structured-deliverablefrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e4a78c38e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
demos/persona_workflow_demo.py
Outdated
| f"{', '.join(product.get('features', []))} into one concise value story." | ||
| ), | ||
| "campaign_hooks": [ | ||
| f"Lead with {product.get('features', ['key features'])[0]} as the hero feature", |
There was a problem hiding this comment.
Guard against empty feature lists in campaign hook
When task_input.product.features is present but empty (e.g., "features": []), indexing product.get('features', ['key features'])[0] raises IndexError and aborts the workflow before the marketing result/final deliverable is produced. Since this commit introduces dynamic task input, empty feature arrays are a realistic input shape and should fall back to a default hook instead of crashing.
Useful? React with 👍 / 👎.
Summary:
Validation:
Notes: