Skip to content

feat: integrate dynamic task input into persona workflow#12

Merged
joy7758 merged 2 commits intopersona-structured-deliverablefrom
dynamic-task-input
Mar 15, 2026
Merged

feat: integrate dynamic task input into persona workflow#12
joy7758 merged 2 commits intopersona-structured-deliverablefrom
dynamic-task-input

Conversation

@joy7758
Copy link
Owner

@joy7758 joy7758 commented Mar 15, 2026

Summary:

  • add a task input JSON file for the persona workflow demo
  • make the workflow read dynamic task data and shape each persona stage from that input
  • write the final structured deliverable to demos/generated/*.json

Validation:

  • ran python3 demos/persona_workflow_demo.py
  • verified the generated deliverable JSON file was written

Notes:

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e4a78c38e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

f"{', '.join(product.get('features', []))} into one concise value story."
),
"campaign_hooks": [
f"Lead with {product.get('features', ['key features'])[0]} as the hero feature",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard against empty feature lists in campaign hook

When task_input.product.features is present but empty (e.g., "features": []), indexing product.get('features', ['key features'])[0] raises IndexError and aborts the workflow before the marketing result/final deliverable is produced. Since this commit introduces dynamic task input, empty feature arrays are a realistic input shape and should fall back to a default hook instead of crashing.

Useful? React with 👍 / 👎.

@joy7758 joy7758 merged commit b41f58c into persona-structured-deliverable Mar 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant