chore(rc1): harden preflight binding, acceptance metrics, and pages publish contract#17
chore(rc1): harden preflight binding, acceptance metrics, and pages publish contract#17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 457302aad0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "preflight_bound_count": float(preflight_bound_count), | ||
| "preflight_bound_rate": (preflight_bound_count / effective_total) if effective_total else 0.0, |
There was a problem hiding this comment.
Exclude infra-invalid rows from preflight_bound_rate
If any task row is classified as INFRA_INVALID after the run-level preflight succeeds (for example, a provider/auth failure during execution), that row still carries preflight_digest and is counted in preflight_bound_count, but effective_total removes it from the denominator. In that case summarize_acceptance() can emit impossible values like preflight_bound_rate == 2.0 for one valid row plus one infra-invalid row, which then propagates into MetricsTracker.summary() and the generated reports. Either filter infra-invalid rows out of the numerator or divide by total instead.
Useful? React with 👍 / 👎.
| "governor_file", | ||
| "governor", |
There was a problem hiding this comment.
Drop unconditional governor keys from the Pages schema
metrics/report.py only adds the top-level governor_file/governor fields when the CLI was actually given a governor run (if "governor" in modes at metrics/report.py:425-427), but this manifest now requires those keys on every published comparison.json. A valid report such as --baseline ... --eco ... will therefore fail the new schema check in the Pages workflow even though governor-less mode sets are explicitly supported.
Useful? React with 👍 / 👎.
Scope
Why
Close protocol exploit surfaces identified in RC1 review:
Validation