reduce GPIO output threshold for recoil events to accomodate both I/O board types #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! Would it make sense to make this configurable per game in the future? |
Contributor
Author
I thought about it, but it is only two games, currently, that have working recoil to begin with, and they're both fine w/ 0x50 . . . I am still poking at Cobra intermittently to try to figure out how recoil worked there - if I/someone ever figures that out maybe additional config will make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, #1516 broke recoil for TC3, as the recoil output signal has a lower value for whatever reason (0x50 rather than 0xC0) when using the MIU type I/O board. This sets the threshold lower for writing a recoil event via the network output and fixes recoil in TC3.