Add additional diagnostic logging for transfers#885
Draft
jpdillingham wants to merge 4 commits intomasterfrom
Draft
Add additional diagnostic logging for transfers#885jpdillingham wants to merge 4 commits intomasterfrom
jpdillingham wants to merge 4 commits intomasterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
- Coverage 98.64% 98.43% -0.21%
==========================================
Files 184 184
Lines 6428 6470 +42
Branches 991 997 +6
==========================================
+ Hits 6341 6369 +28
- Misses 63 73 +10
- Partials 24 28 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds an additional callback to transfer options and wraps diagnostic statements so that they are sent as typical diagnostics, and the callback. This will allow for all diagnostic messages on an individual transfer record to be grouped and logged together, which is something that is very challenging today when trying to review application behavior under heavy load.
I'm not sure I really need this for the time being, so I'll leave this open in draft mode for now.