-
Notifications
You must be signed in to change notification settings - Fork 1.5k
PROXY v2 support #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
PROXY v2 support #552
Conversation
@jpillora any this could get merged into main and into the next release? |
I really want to get this feature merged. I resolved the merge conflicts in my branch if that helps: https://github.com/Skaronator/chisel/commits/proxy-protocol/ I also made a custom release available:
Currently running this in my homelab and works great with Envoy Gateway API as Reverse Proxy. |
@lleyton can you merge in the changes from @Skaronator ? |
this is great stuff. However, from the commits it looks like "P" is only available for the "R" reverse proxy? In my case, I am using a normal forward proxy and want chisel to log the "real-ip" passed to it from the nginx in front of it: nginx.conf
possible? |
Use Proxy Protocol on nginx. That's how we are getting the correct client iP. |
Not quite sure what you mean.
but I am running the chisel server with -v: chisel server --host 127.0.0.1 --port 8081 --auth tunnel:password -v and due to the abovementioned line in
I was hoping that chisel would pick up this information from the
Does that make sense? |
@oschonrock which chisel version are you using? With the one from @lleyton it lets you enable proxy protocol and if your nginx has proxy protocol enabled it'll get the IP. Not sure if this applies for FOSS nginx but something like this: https://docs.nginx.com/nginx/admin-guide/load-balancer/using-proxy-protocol/#configure-nginx-to-accept-the-proxy-protocol |
I am currently using 1.11.3, not the @lleyton branch But I looked at the commits on his branch and that seemed to allow "P" only in combination with "R". How would I "enable proxy protocol" on the @lleyton branch for this "forward proxy" situation? |
Sorry i missunderstood your original ask. I was thinking you wanted to have nginx log it out not chisel. I can't help you with this. Maybe @lleyton or @Skaronator can chime in here. |
That isn't supported in my PR, I honestly never thought there was a usecase for that. I might be interested in working on that in a different PR. |
Closes #540