add maximum quadrature function and test#3
Merged
jpmorgan98 merged 2 commits intojpmorgan98:mainfrom Dec 17, 2025
Merged
Conversation
jpmorgan98
requested changes
Dec 17, 2025
Owner
jpmorgan98
left a comment
jpmorgan98
left a comment
There was a problem hiding this comment.
Not passing tests, but very close! I like the feature and want it in the repo. Just fix the tests and I think we can get this rad PR incorporated! (ﾉ◕ヮ◕)ﾉ
|
|
||
| x = np.random.random(10) | ||
| quad = rad.quadrature(4) | ||
| psi_m = quad.maximum(x) |
Owner
There was a problem hiding this comment.
Hmmm you're tests didn't pass and I think's its this line which is supposed to be calculate_maximum_flux
Contributor
Author
|
YEAH WHO CARES ABOUT LINTING |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be really cool to have a feature to evaluate the maximum angular flux in an array. I added a test. LMK WHAT YOU THINK!!!!!!!!!