Skip to content

fix: use the urlencoding crate instead of manual replacement of special characters #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacksongoode merged 1 commit into from
Dec 19, 2025
Merged

fix: use the urlencoding crate instead of manual replacement of special characters #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions psst-gui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ time-humanize = { version = "0.1.3" }
ureq = { version = "3.0.11", features = ["json", "socks-proxy"] }
url = { version = "2.5.4" }
infer = "0.19.0"
urlencoding = { version = "2.1.3" }

# GUI
druid = { git = "https://github.com/jpochyla/druid", branch = "psst", features = [
Expand Down
3 changes: 2 additions & 1 deletion psst-gui/src/webapi/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,9 +1336,10 @@ impl WebApi {
shows: Option<Page<Arc<Show>>>,
}

let encoded_query = urlencoding::encode(query);
let type_query_param = topics.iter().map(SearchTopic::as_str).join(",");
let request = &RequestBuilder::new("v1/search", Method::Get, None)
.query("q", query.replace(" ", "%20"))
.query("q", encoded_query)
.query("type", &type_query_param)
.query("limit", limit.to_string())
.query("marker", "from_token");
Expand Down