Skip to content

Build: Separate Node.js & Browser Tests, update tested Node.js versions #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build: Separate Node.js & Browser Tests, update tested Node.js versions #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 117 additions & 0 deletions .github/workflows/browser-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
name: Browser Tests

on:
pull_request:
push:
branches-ignore: "dependabot/**"
# Once a week every Monday
schedule:
- cron: "42 1 * * 1"

permissions:
contents: read

env:
NODE_VERSION: 22.x

jobs:
build-and-test:
runs-on: ubuntu-latest
name: |
${{ matrix.BROWSER }} | ${{ matrix.CONFIGS.name }}
strategy:
fail-fast: false
matrix:
BROWSER: [chrome, firefox]
CONFIGS:
- config: jtr-git.yml
name: jQuery git
- config: jtr-stable.yml
name: jQuery stable

steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install npm dependencies
run: npm ci

- name: Build
run: npm run build

- name: Test
run: |
npm run test:unit -- \
--headless -b ${{ matrix.BROWSER }} \
-c ${{ matrix.CONFIGS.config }}

edge:
runs-on: windows-latest
name: |
edge | ${{ matrix.CONFIGS.name }}
strategy:
fail-fast: false
matrix:
CONFIGS:
- config: jtr-git.yml
name: jQuery git
- config: jtr-stable.yml
name: jQuery stable
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

- name: Test
run: npm run test:unit -- --headless -b edge -c ${{ matrix.CONFIGS.config }}

safari:
runs-on: macos-latest
name: |
safari | ${{ matrix.CONFIGS.name }}
strategy:
fail-fast: false
matrix:
CONFIGS:
- config: jtr-git.yml
name: jQuery git
- config: jtr-stable.yml
name: jQuery stable
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

- name: Test
run: npm run test:unit -- -b safari -c ${{ matrix.CONFIGS.config }}
85 changes: 1 addition & 84 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
pull_request:
push:
branches-ignore: "dependabot/**"
# Once a week every Monday
schedule:
- cron: "42 1 * * 1"

permissions:
contents: read
Expand All @@ -17,17 +14,7 @@ env:
jobs:
build-and-test:
runs-on: ubuntu-latest
name: |
${{ matrix.BROWSER }} | ${{ matrix.CONFIGS.name }}
strategy:
fail-fast: false
matrix:
BROWSER: [chrome, firefox]
CONFIGS:
- config: jtr-git.yml
name: jQuery git
- config: jtr-stable.yml
name: jQuery stable
name: Build & lint

steps:
- name: Checkout
Expand All @@ -49,73 +36,3 @@ jobs:
# Lint must happen after build as we lint generated files.
- name: Lint
run: npm run lint

- name: Test
run: |
npm run test:unit -- \
--headless -b ${{ matrix.BROWSER }} \
-c ${{ matrix.CONFIGS.config }}

edge:
runs-on: windows-latest
name: |
edge | ${{ matrix.CONFIGS.name }}
strategy:
fail-fast: false
matrix:
CONFIGS:
- config: jtr-git.yml
name: jQuery git
- config: jtr-stable.yml
name: jQuery stable
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

- name: Test
run: npm run test:unit -- --headless -b edge -c ${{ matrix.CONFIGS.config }}

safari:
runs-on: macos-latest
name: |
safari | ${{ matrix.CONFIGS.name }}
strategy:
fail-fast: false
matrix:
CONFIGS:
- config: jtr-git.yml
name: jQuery git
- config: jtr-stable.yml
name: jQuery stable
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
cache: npm
cache-dependency-path: '**/package-lock.json'

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build

- name: Test
run: npm run test:unit -- -b safari -c ${{ matrix.CONFIGS.config }}
Loading