exit all worker/fetcher/manager correctly#58
Closed
LYY wants to merge 9 commits intojrallison:masterfrom
Closed
Conversation
Author
|
need test more |
Author
|
many changs |
Contributor
|
Why closing that ? @LYY |
Author
|
@Soulou I changed too much codes for my own purpose, so this PR could not be merged. I will create a new branch to commit the fixes. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a production environment based on go-workers. I used runit for daemon. While it run a few days, I send "term" signal to stop it, but it can't stopped.
I check code of go-workers, and guess the bug is worker/fetcher/manager not exit correctly.
About "for" "select" break:
test1: http://play.golang.org/p/l01ImEBCwv
test2: http://play.golang.org/p/pLQarqtZdg