Skip to content

fix break on exit #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LYY wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fix break on exit #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
df84997
exit worker goroutine on stop
LYY Oct 23, 2015
4417037
fix break "for" "select" case to exit
LYY Oct 28, 2015
60f3ea6
change break label name
LYY Oct 28, 2015
e3bf0e2
change break label name
LYY Oct 28, 2015
0181299
quit test
LYY Nov 3, 2015
1cc4ae8
remove test log
LYY Nov 9, 2015
619983f
fix quit
LYY Nov 9, 2015
f747a9e
fix data race
LYY Dec 24, 2015
69df03f
add go1.5 travis
LYY Dec 24, 2015
a7cafdf
replace to own
LYY Dec 25, 2015
efa77fe
travis ci
LYY Dec 25, 2015
1022931
travis ci
LYY Dec 25, 2015
7151f9c
travis ci status
LYY Dec 25, 2015
6be9ac8
Merge branch 'master' of https://github.com/jrallison/go-workers into…
LYY Feb 22, 2016
41258ea
restore readme to jrallision
LYY Feb 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Example usage:
package main

import (
"github.com/jrallison/go-workers"
"github.com/jrallison/go-workers"
)

func myJob(message *workers.Msg) {
Expand Down
3 changes: 2 additions & 1 deletion manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,14 @@ func (m *manager) manage() {

go m.fetch.Fetch()

Lmanage:
for {
select {
case message := <-m.confirm:
m.fetch.Acknowledge(message)
case <-m.stop:
m.exit <- true
break
break Lmanage
}
}
}
Expand Down
4 changes: 3 additions & 1 deletion worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func (w *worker) quit() {
}

func (w *worker) work(messages chan *Msg) {
Lwork:
for {
select {
case message := <-messages:
Expand All @@ -40,9 +41,10 @@ func (w *worker) work(messages chan *Msg) {
// ready to accept a message
case <-w.stop:
w.exit <- true
return
break Lwork
}
}

}

func (w *worker) process(message *Msg) (acknowledge bool) {
Expand Down