Skip to content

Delegates features list request to rollout#27

Open
pote wants to merge 1 commit intojrallison:masterfrom
pote:broken_rollout_features
Open

Delegates features list request to rollout#27
pote wants to merge 1 commit intojrallison:masterfrom
pote:broken_rollout_features

Conversation

@pote
Copy link
Copy Markdown

@pote pote commented Apr 14, 2014

#features was returning an empty array on my app - I'm setting it up from scratch with the latest version of rollout.

I noticed $rollout does actually have a shortcut for its features, so I'm delegating the wrapper's call to rollout instead of relying on its own separate implementation, fixes my problem. :)

@kyleries
Copy link
Copy Markdown
Collaborator

@pote - Thanks for the PR! We're working on addressing this discrepancy currently but will likely not go down the path of using ActiveSupport#delegate for the same reasons mentioned here #3 . Let me know if you disagree, otherwise I'll be closing this issue. Glad it worked for you though. 😉

If you'd like to submit an alternative, feel free, otherwise #25 is looking promising if you'd like to experiment with, or weigh in on, that solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants