Fix: librosa.feature.melspectrogram have argument error#21
Open
tset-tset-tset wants to merge 1 commit intojrgillick:masterfrom
Open
Fix: librosa.feature.melspectrogram have argument error#21tset-tset-tset wants to merge 1 commit intojrgillick:masterfrom
tset-tset-tset wants to merge 1 commit intojrgillick:masterfrom
Conversation
|
replace line 228 of /content/laughter-detection/./utils/audio_utils.py with this: |
nacho-correa
approved these changes
Feb 4, 2025
nacho-correa
left a comment
There was a problem hiding this comment.
Came here to propose the same changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi jrgillick,
Now I tried to run it on the following notebook, but it was giving me errors, so I checked the cause.
See https://github.com/tset-tset-tset/hoge/blob/master/laughter-detection-interactive.ipynb for more information.
The error is not only happening when running from the notebook, but also when running
segment_laughter.pyscript.I think this fix will fix the error. Could you please check?