Skip to content

test escape apos#52

Closed
ahorek wants to merge 1 commit intojruby:masterfrom
ahorek:apos
Closed

test escape apos#52
ahorek wants to merge 1 commit intojruby:masterfrom
ahorek:apos

Conversation

@ahorek
Copy link
Copy Markdown
Contributor

@ahorek ahorek commented Feb 9, 2022

a test for https://bugs.ruby-lang.org/issues/16922

it should pass after tables update from #49 but there's still a problem

TestEConv.testEscapeApos:90 expected:<&amp;[&apos;&amp;]> but was:<&amp;[]>

am I doing something wrong? or is there something else that should be adjusted?

ref #45

@headius
Copy link
Copy Markdown
Member

headius commented Mar 16, 2022

Hmm not sure what the issue is here.

@ahorek
Copy link
Copy Markdown
Contributor Author

ahorek commented Mar 16, 2022

' should now be escaped as &apos;
the same way as
& is escaped as &amp;

but the test fails and I didn't find out where the problem is.

@ahorek
Copy link
Copy Markdown
Contributor Author

ahorek commented Mar 16, 2022

since it's passing on the latest JRuby snapshot that includes this change, there's probably something wrong with the test itself.

#56 will be the ultimate solution for a better coverage

closing

@ahorek ahorek closed this Mar 16, 2022
@headius headius added this to the invalid/duplicate/wontfix milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants