This repository was archived by the owner on Mar 16, 2022. It is now read-only.
Open
Conversation
Test was failing.
Using the --all feature broke in this change. Reverting this also fixes a test that was -rightfully- breaking after this change.
Running cucumber flunked with an error, as it tried to load the debugger gem, which was removed in 1f57521. I'm removing it entirely for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cucumber broke due to the recently merged changes.
Seems like the CI and developer did not run cucumber or did not catch these. Fixed in this PR.
Cause could be that
rake, the default task, only runs rspec and not all the tests. This may be confusing: cucumber has to be ran explicitly and manually.