Remove redundant hasOwnProperty check and update travis testing#4
Open
reyawn wants to merge 2 commits intojsdf:masterfrom
Open
Remove redundant hasOwnProperty check and update travis testing#4reyawn wants to merge 2 commits intojsdf:masterfrom
reyawn wants to merge 2 commits intojsdf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The additional
hasOwnPropertycheck is unneeded:Object.prototype.hasOwnPropertychecks if a property is found directly on an object (see hasOwnProperty).Object.getOwnPropertyNamesreturns all properties found directly on an object (see getOwnPropertyNames).This PR removes the unneeded
hasOwnPropertycheck since it is being performed on the output fromObject.getOwnPropertyNames.It also somewhat "modernizes" the travis tests, dropping testing against the archaic
0.6and0.8versions and adding the more likely0.10and up stable versions as well as testing against the latest release.