This repository was archived by the owner on Oct 28, 2019. It is now read-only.
Allow quicksell custom value to be specified as a percentage#1451
Open
rvaidya wants to merge 3 commits intojshackles:devfrom
Open
Allow quicksell custom value to be specified as a percentage#1451rvaidya wants to merge 3 commits intojshackles:devfrom
rvaidya wants to merge 3 commits intojshackles:devfrom
Conversation
seeeeew
suggested changes
Oct 7, 2017
Contributor
seeeeew
left a comment
seeeeew
left a comment
There was a problem hiding this comment.
I like the idea, but you should add new strings to localization/en/strings.json so translators on Crowdin can translate them.
Add new strings to translation for quicksell-percent
Author
|
Thanks! |
Author
|
Is there any more info needed for this? I'd like to go back to using the official extension so Chrome stops nagging me about developer extensions. |
Author
|
@jshackles My use case for this is for selling cards at a small percentage markup from the current price so they generate a bit more on the market and don't sell too quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.