Add a test for respecting dynamic scopes while avoiding the root of each schema #794
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notEthan
reviewed
Nov 15, 2025
…ach schema We $ref from base -> first#/$defs/stuff -> second#/$defs/stuff -> third#/$defs/stuff and then follow a $dynamicRef to #length. At no point do we ever actually evaluate at the root schema for each scope. The dynamic scope is [ base, first, second, third ] and we check the scopes in order, therefore the first scope we find with a dynamic anchor "length" is "second".
karenetheridge
force-pushed
the
ether/dynamic-scopes-subschemas
branch
from
856ebed to
19810ec
Compare
karenetheridge
added a commit
to karenetheridge/JSON-Schema-Modern
that referenced
this pull request
Nov 17, 2025
Dynamic scopes were only being recorded while evaluating an $id keyword, but if we follow a $ref targeting a sub-resource that lacked an $id but is in a different namespace, the new scope was never recorded. See also json-schema-org/JSON-Schema-Test-Suite#794
jdesrosiers
approved these changes
Nov 17, 2025
notEthan
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We $ref from base -> first#/$defs/stuff -> second#/$defs/stuff -> third#/$defs/stuff and then follow a $dynamicRef to #length. At no point do we ever actually evaluate at the root schema for each scope. The dynamic scope is [ base, first, second, third ] and we check the scopes in order, therefore the first scope we find with a dynamic anchor "length" is "second".
This revealed a bug in my implementation, where dynamic scopes were only being recorded while evaluating an $id keyword, but not when using a $ref that went to a sub-resource that lacked an $id.