-
-
Notifications
You must be signed in to change notification settings - Fork 281
fix: add "Go Back" and "Up Next" navigation buttons for Specification… #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @vtushar06! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: completed checklist items Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 448 448
Branches 116 116
=========================================
Hits 448 448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey @vtushar06 , thanks a lot for your contribution, really appreciate you taking the time to work on this! To keep things clean and easy to review, I’d suggest closing this PR and opening a new one with just the necessary changes for the issue. Let me know if you need any help with that, happy to guide you through it! 🙌 Thank You! |
ofcourse @Utkarsh-123github, I will go through this and will update you soon. |
hey @Utkarsh-123github , I Raised a new PR for this particular issue, now this PR can be closed as i Raised #1743 you can now review that. |
Closing this PR as requested by author #1708 (comment) |
… versions (#1618)
What kind of change does this PR introduce?
Bugfix — improves UI/UX through enhanced navigation between Specification version pages.
Issue Number:
• Closes #1618
Screenshots/videos:
https://github.com/user-attachments/assets/7815d73e-23ed-4cb0-9b75-693a8bb183b1
If relevant, did you update the documentation?
Not applicable — changes are limited to component-level enhancements.
Summary
This pull request addresses the missing "Go Back" and "Up Next" navigation buttons across the Specification version pages, as discussed in issue #1618.
As part of this contribution:
• I implemented a reusable navigation component for consistency.
• Integrated the component into five Specification version pages to ensure seamless traversal across document versions.
• Validated the functionality across all affected routes for correct previous/next link logic.
• Ensured the code adheres to existing linting and styling standards.
These enhancements improve overall documentation navigation flow and accessibility for users referring to different spec versions.
Does this PR introduce a breaking change?
No — the implementation is fully backward compatible and isolated to specific pages.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
ScreenRecording.mp4