Skip to content

fix: add "Go Back" and "Up Next" navigation buttons for Specification… #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vtushar06
Copy link

@vtushar06 vtushar06 commented Jun 14, 2025

… versions (#1618)

What kind of change does this PR introduce?
Bugfix — improves UI/UX through enhanced navigation between Specification version pages.

Issue Number:
Closes #1618

Screenshots/videos:
https://github.com/user-attachments/assets/7815d73e-23ed-4cb0-9b75-693a8bb183b1

If relevant, did you update the documentation?
Not applicable — changes are limited to component-level enhancements.

Summary
This pull request addresses the missing "Go Back" and "Up Next" navigation buttons across the Specification version pages, as discussed in issue #1618.
As part of this contribution:
• I implemented a reusable navigation component for consistency.
• Integrated the component into five Specification version pages to ensure seamless traversal across document versions.
• Validated the functionality across all affected routes for correct previous/next link logic.
• Ensured the code adheres to existing linting and styling standards.

These enhancements improve overall documentation navigation flow and accessibility for users referring to different spec versions.

Does this PR introduce a breaking change?
No — the implementation is fully backward compatible and isolated to specific pages.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

ScreenRecording.mp4

@vtushar06 vtushar06 requested a review from a team as a code owner June 14, 2025 19:47
Copy link

Hi @vtushar06! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Jun 14, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview b337b74

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ac0817) to head (b337b74).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1708   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          448       448           
  Branches       116       116           
=========================================
  Hits           448       448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member

Hey @vtushar06 , thanks a lot for your contribution, really appreciate you taking the time to work on this!
It looks like you might have missed pulling the latest changes from the main branch before making your updates. Because of that, the PR includes some extra file changes (17000+ lines of change) that aren't needed for fixing the related issue.

To keep things clean and easy to review, I’d suggest closing this PR and opening a new one with just the necessary changes for the issue. Let me know if you need any help with that, happy to guide you through it! 🙌

Thank You!

@vtushar06
Copy link
Author

ofcourse @Utkarsh-123github, I will go through this and will update you soon.
We will complete this issue by today itself
Thanks a lot for review.
@vtushar06

@vtushar06
Copy link
Author

hey @Utkarsh-123github , I Raised a new PR for this particular issue, now this PR can be closed as i Raised #1743 you can now review that.
thanks a lot,
@vtushar06

@Utkarsh-123github
Copy link
Member

Closing this PR as requested by author #1708 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: "Go Back" and "Up Next" buttons are missing for Specification versions
2 participants