-
-
Notifications
You must be signed in to change notification settings - Fork 281
fix: Enhance DocsHelp component with comment validation and state management #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Enhance DocsHelp component with comment validation and state management #1746
Conversation
@idanidan29 ive created a new PR now this branch have no conflicts and has include recent changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, Just a small thing please take care of the linting error flagged by GitHub Actions:
Error: 135:11 error 'formData' is assigned a value but never used @typescript-eslint/no-unused-vars
…vote value from form, removing unnecessary FormData usage.
…ariable for improved readability and maintainability.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
===========================================
- Coverage 100.00% 99.11% -0.89%
===========================================
Files 29 29
Lines 548 563 +15
Branches 158 164 +6
===========================================
+ Hits 548 558 +10
- Misses 0 5 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@idanidan29 ive fixed the linting error, please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just missing test coverage for comment validation and the error message. Adding those would make it solid. Check the Codecov report for details on which lines to cover, we need those to keep project coverage at 100%.
What kind of change does this PR introduce?
Bug Fix: Fixed a bug that allowed blank feedback submissions by enforcing comment field validation
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
NA
Checklist
Please ensure the following tasks are completed before submitting this pull request.