V3 to v4 crs#9
Merged
jsrobinson3 merged 4 commits intomainfrom Mar 5, 2026
Merged
Conversation
- Create insight/sshLogin.json: SSH login monitor dashboard with failed/successful login stats, unique logins (user+IP pairs), login trends, top offending IPs, targeted usernames, and auth log stream - Fix security2.conf template: move netsapiens-exclusions.conf include to after CRS rules so SecRuleUpdateTargetById directives can find the rules they modify (fixes 932270 cookie false positives) - Update README with sshLogin.json in iNSight Templates list
- Delete rules/crs/ and rules/netsapiens/ (now Jinja2 templates in config.py) - Refactor waf_commands, restrict, and status modules - Replace Optional[X]/Union[X,Y] with X | None / X | Y across codebase - Fix ambiguous variable names and unused assignments in tests - Add WAF iNSight dashboard screenshot
Resolve conflicts preferring branch formatting: - Keep modern type annotations (str | None vs Optional[str]) - Keep NS_EXCLUSIONS_VERSION = "3" (newer template) - Keep consistent line formatting for with statements and f-strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.