Improved `Chain.build()` performance by 1/3 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

egormanga wants to merge 1 commit into jsvine:master from egormanga:fix/setdefault

+5 −9

egormanga commented Jan 24, 2026

Using dict.setdefault() is much faster than doing a separate dict.__contains__() check each iteration. This gives us ~1/6× better performance.
But keeping the in-place addition and falling back by catching KeyError gives another 1/6 over using dict.get().


          Improved Chain.build() performance by 1/3.

9c29e9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet