Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/rules/forbid-dom-props.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ module.exports = {

return {
JSXAttribute(node) {
const tag = node.parent.name.name;
if (!(tag && typeof tag === 'string' && tag[0] !== tag[0].toUpperCase())) {
// This is a Component, not a DOM node, so exit.
const parentName = node.parent.name;
// Extract a component name when using a "namespace", e.g. `<html.div />`.
const tag = parentName.name || `${parentName.object.name}.${parentName.property.name}`;
const componentName = parentName.name || parentName.property.name;
const isDomNode = componentName && typeof componentName[0] === 'string' && componentName[0] !== componentName[0].toUpperCase();
if (!isDomNode) {
return;
}

Expand Down
42 changes: 40 additions & 2 deletions tests/lib/rules/forbid-dom-props.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ ruleTester.run('forbid-dom-props', rule, {
code: `
class First extends createReactClass {
render() {
return <this.foo id="bar" />;
return <this.foo className="bar" />;
}
}
`,
options: [{ forbid: ['id'] }],
options: [{ forbid: ['style'] }],
},
{
code: `
Expand Down Expand Up @@ -112,6 +112,17 @@ ruleTester.run('forbid-dom-props', rule, {
},
],
},
{
code: `
const First = (props) => (
<html.span name="foo" />
);
const Second = (props) => (
<h.span name="foo" />
);
`,
options: [{ forbid: ['id'] }],
},
]),

invalid: parsers.all([
Expand Down Expand Up @@ -324,5 +335,32 @@ ruleTester.run('forbid-dom-props', rule, {
},
],
},
{
code: `
const First = (props) => (
<html.div id="foo" />
);
const Second = (props) => (
<h.div id="foo" />
);
`,
options: [{ forbid: ['id'] }],
errors: [
{
messageId: 'propIsForbidden',
data: { prop: 'id' },
line: 3,
column: 21,
type: 'JSXAttribute',
},
{
messageId: 'propIsForbidden',
data: { prop: 'id' },
line: 6,
column: 18,
type: 'JSXAttribute',
},
],
},
]),
});
Loading