JC-2292 bug fixes#188
Merged
ctapobep merged 1 commit intojtalks-org:masterfrom Mar 16, 2016
raimdev:master
Merged
Conversation
- Groups are not sorted via alphabet - Group list is blinking after first opening - Groups multi select box is not translated on Russian and Ukrainian. -Tab key does not move focus to the Groups button - Network connection alert message has an html number of a single quote instead of a single quote symbol
| $pollItemLength = '<spring:message code="poll.item.length" htmlEscape="true" text=""/>'; | ||
|
|
||
| $labelConnectionLostGenericError = '<spring:message code="label.connection.lost.genericError" htmlEscape="true"/>'; | ||
| $labelConnectionLostGenericError = "<spring:message code="label.connection.lost.genericError" htmlEscape="false"/>"; |
Member
There was a problem hiding this comment.
This would allow for HTML Injections, wouldn't it? If we change the message at some point in the future there is a risk that we break HTML.
Contributor
Author
There was a problem hiding this comment.
then, maybe we should use "`" symbol for "З'єднання" word?
Member
There was a problem hiding this comment.
No, that's hackish. We've got this symbol in other places, how is it working there?
Contributor
Author
There was a problem hiding this comment.
Key label.announcement (Помітити як об'яву) used in topicForm.jsp:
<spring:message code="label.announcement"/>
without escape
Member
There was a problem hiding this comment.
Okay then, let's leave it. I guess this issue relates to #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed next bugs:
-Tab key does not move focus to the Groups button