JC-963 An incorrect message appears when a user performs the 'Remove …#288
Open
keik13 wants to merge 1 commit intojtalks-org:masterfrom
Open
JC-963 An incorrect message appears when a user performs the 'Remove …#288keik13 wants to merge 1 commit intojtalks-org:masterfrom
keik13 wants to merge 1 commit intojtalks-org:masterfrom
Conversation
…avatar' action for an empty avatar. Added disable button "Remove avatar", if the avatar default. Checks 2 cases: 1. when a default avatar has never changed. 2. when a user downloads your avatar, but then deleted it and it changed to the default avatar. Avatars in these cases differ by their size, etc.
Member
|
Hi, @keik13 I thought more on this and I think it's not that important for the end user but in the same time the performance is going to be a bit worse. So my inclination would be not to merge this. Sorry for the misleading JIRA state.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…avatar' action for an empty avatar.
Added disable button "Remove avatar", if the avatar default.
Checks 2 cases:
to the default avatar.
Avatars in these cases differ by their size, etc.