This repository was archived by the owner on Nov 8, 2018. It is now read-only.
Include PR author user_login in metadata#104
Merged
jtarchie merged 1 commit intojtarchie:masterfrom Sep 6, 2017
Merged
Conversation
Contributor
Author
|
@jtarchie I cannot see CI to see what the CI failure is. Can you make your PR job public please so I can fix my PR? |
Owner
|
You should be able to run the tests locally. |
Contributor
Author
|
@jtarchie thanks, test failures fixed. |
Owner
|
Released in v28. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards the possible implementation of whitelist protection in subsequent task steps before doing insecure builds/deployments
Verification from using this branch upon egen/concourse-pullrequest-playtime#1 in https://ci.starkandwayne.com/teams/main/pipelines/concourse-pullrequest-playtime/jobs/test-pr/builds/9. Within the
test-prcontainer, the.../git-pull-requestsfolder haspullrequest.userloginconfig: