Skip to content
This repository was archived by the owner on Nov 8, 2018. It is now read-only.

Include PR author user_login in metadata#104

Merged
jtarchie merged 1 commit intojtarchie:masterfrom
drnic:user-info
Sep 6, 2017
Merged

Include PR author user_login in metadata#104
jtarchie merged 1 commit intojtarchie:masterfrom
drnic:user-info

Conversation

@drnic
Copy link
Copy Markdown
Contributor

@drnic drnic commented Sep 5, 2017

Towards the possible implementation of whitelist protection in subsequent task steps before doing insecure builds/deployments

Verification from using this branch upon egen/concourse-pullrequest-playtime#1 in https://ci.starkandwayne.com/teams/main/pipelines/concourse-pullrequest-playtime/jobs/test-pr/builds/9. Within the test-pr container, the .../git-pull-requests folder has pullrequest.userlogin config:

# git config --list
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=https://github.com/starkandwayne/concourse-pullrequest-playtime
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
pullrequest.url=https://github.com/starkandwayne/concourse-pullrequest-playtime/pull/1
pullrequest.id=1
pullrequest.branch=drnic-patch-1
pullrequest.basebranch=master
pullrequest.userlogin=starkandwayne

# cat .git/userlogin
starkandwayne

@drnic
Copy link
Copy Markdown
Contributor Author

drnic commented Sep 5, 2017

@jtarchie I cannot see CI to see what the CI failure is. Can you make your PR job public please so I can fix my PR?

@jtarchie
Copy link
Copy Markdown
Owner

jtarchie commented Sep 5, 2017

You should be able to run the tests locally.

@drnic
Copy link
Copy Markdown
Contributor Author

drnic commented Sep 5, 2017

@jtarchie thanks, test failures fixed.

@jtarchie jtarchie merged commit afd3a27 into jtarchie:master Sep 6, 2017
@jtarchie
Copy link
Copy Markdown
Owner

jtarchie commented Sep 6, 2017

Released in v28. Thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants