Github Enterprise PR feedback and improvements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a config value spr.githubApiDomain - collect this during spr init - update regex to not expect 'github.com' - generate PR urls correctly Test plan: Manually tested on my companies github enterprise
This commit builds on the work down and feedback posted in [spacedentist#158](spacedentist#158). It also builds on using Octocrab for GraphQL changes in [spacedentist#187](spacedentist#187) It only sets a base_url if we explicitly specify one for Github Enterprise, otherwise it will use the base url from octocrab for Github Cloud.
spacedentist
added a commit
to spacedentist/spr
that referenced
this pull request
Apr 20, 2025
Remove the manual use of reqwest::Client for graphql queries and use octocrab instead. This removes the need to specify the github api base url multiple times. We instead leverage the global octocrab instance for which we configure the api base url once. This is beneficial for a cleaner implementation of Github Enterprise support (#158), as we can configure the base url once. For an example of what GHE support could look like on top of this, here is a draft PR jtietema#1 --------- Co-authored-by: Sven Over <sp@cedenti.st>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit builds on the work down and feedback posted in #158.
It also builds on using Octocrab for GraphQL changes in #187
It only sets a base_url if we explicitly specify one for Github Enterprise, otherwise it will use the base url from octocrab for Github Cloud.