Unwinding of stack, inclusion of a rectangular bounds search, optimization for large numbers of equal points.#14
Open
ekovac wants to merge 9 commits intojtsiomb:masterfrom
Open
Unwinding of stack, inclusion of a rectangular bounds search, optimization for large numbers of equal points.#14ekovac wants to merge 9 commits intojtsiomb:masterfrom
ekovac wants to merge 9 commits intojtsiomb:masterfrom
Conversation
…timization for equal nodes.
Owner
|
Thank you for the contribution! I'll examine the changes as soon as I find some time, and probably merge them with my branch soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These (incomplete) patches introduce a couple of improvements to jtsiomb/kdtree that wound up being necessary for use in IVPR/Weave.
insert_recandclear_reckd_in_boundsfor doing a rectangular search.Unwinding the recursion is necessary when the number of points is very large. I suggest using the user stack functions I added to also modify the original range query functions, as well as any necessary handling of the equal-point linked list.