Move documentation for how to use this module to the docstring so it's rendered on RTD#672
Open
mthaddon wants to merge 1 commit intojuju:masterfrom
Open
Move documentation for how to use this module to the docstring so it's rendered on RTD#672mthaddon wants to merge 1 commit intojuju:masterfrom
mthaddon wants to merge 1 commit intojuju:masterfrom
Conversation
…s rendered on RTD
|
Might also consider mentioning that this will not build for charms using setuptools > 58 which effectively will break all builds with charmcraft as of today. So, basically, its broken with charmcraft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the documentation on https://charm-helpers.readthedocs.io/en/latest/api/charmhelpers.contrib.charmsupport.html only renders as one line that's not very useful. Move the documentation from comments lower down in the file to the docstring.