Add -S option when calling add-apt-repository for a line starting with deb#771
Open
verterok wants to merge 2 commits intojuju:masterfrom
Open
Add -S option when calling add-apt-repository for a line starting with deb#771verterok wants to merge 2 commits intojuju:masterfrom
verterok wants to merge 2 commits intojuju:masterfrom
Conversation
verterok
changed the title
verterok
changed the title
Author
|
Take this as an idea on a possible fix, I'm far from an expert on charmhelper internals and this also requires some tests. |
ajkavanagh
suggested changes
Apr 20, 2023
Contributor
ajkavanagh
left a comment
ajkavanagh
left a comment
There was a problem hiding this comment.
Thanks very much for the code suggestion. I don't then the suggested patch actually works, and it definitely needs unit tests to verify that it does what is expected, please.
ajkavanagh
added
the
Incomplete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only for jammy or newer, and it just bypass any custom ppa logic in add-apt-repository by passing
-Sif the source line starts with deb.fixes #770