Open
Conversation
get_ipv6_addr: the if condition was checking for the eui 64 mac address, but that has nothing to do with global ipv6 addresses. I added and fixed existing tests accordingly. The DNS resolver tests were not expecting a NoAnswer that is returned if the query is done against a non-authoritative recursor. Finally fixed a typo in a test name: loopup -> lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran make tests and they all pass.
The DNS issue is not reported because I ran into it while testing my changes.
This is my first time contributing to anything open source, so I would love your feedback on this merge request : )
Fixes #877
PS: as cited in the issue, I ran into this while using ceph-osd.
Manually changing the file like in this merge request fixed it.