Add the ability to specify PCI address in dpdk-bond-mappings.#956
Draft
PanosKostopoulos wants to merge 1 commit intojuju:masterfrom
Draft
Add the ability to specify PCI address in dpdk-bond-mappings.#956PanosKostopoulos wants to merge 1 commit intojuju:masterfrom
PanosKostopoulos wants to merge 1 commit intojuju:masterfrom
Conversation
Since mac addresses change often in deployment, an option for specifying PCI address is very useful. Signed-off-by: Panos Kostopoulos Kyrimis <panos.kostopouloskyrimis@canonical.com>
6328f10 to
37a6c73
Compare
fnordahl
requested changes
Apr 15, 2026
|
|
||
| return resolved_devices | ||
|
|
||
| PCI_REGEX = r'^([0-9a-fA-F]{4}:)?[0-9a-fA-F]{2}:[0-9a-fA-F]{2}\.[0-7]$' |
Contributor
There was a problem hiding this comment.
- The purpose of the
resolve_pci_from_mapping_configfunction is to translate MAC into PCI addresses and as such I'd not modify it for your purpose.
Instead, I'd suggest to create a new function that can be called from somewhere around here:charm-helpers/charmhelpers/contrib/openstack/context.py
Lines 2698 to 2712 in 5488b35
- Regular expressions are prohibitively difficult to read and maintain, please make use of the rich Python string helpers instead, there is some potential inspiration in the
parse_*functions here:charm-helpers/charmhelpers/contrib/openstack/neutron.py
Lines 274 to 351 in 5488b35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since mac addresses change often in deployment, an option for specifying PCI address is very useful.