(stable/yoga) Add proxy protocol support for real client IP logging#962
Open
xtrusia wants to merge 3 commits intojuju:stable/yogafrom
Open
(stable/yoga) Add proxy protocol support for real client IP logging#962xtrusia wants to merge 3 commits intojuju:stable/yogafrom
xtrusia wants to merge 3 commits intojuju:stable/yogafrom
Conversation
Currently, log shows proxy IP but need actual client IP. This patch adds required module and configuration to setup options for Apache2 templates and haproxy templates. Use PROXY protocol v1 (send-proxy) instead of v2 (send-proxy-v2) to avoid Apache mod_remoteip incompatibility with PROXYv2 LOCAL command (unsupported command 0x20) during health checks. Also adds missing 'check' keyword to haproxy server lines to ensure health checks are properly performed. Closes-bug: LP#2107999 Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com> (cherry picked from commit f516806)
Add ::1 to the RemoteIPProxyProtocolExceptions directive alongside 127.0.0.1 to properly handle IPv6 loopback connections in both the HTTPS frontend and WSGI templates. Closes-Bug: #2107999 Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com> (cherry picked from commit ccdc2bd)
Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com> (cherry picked from commit 63c009c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, log shows proxy ip but need actual client ip
This PR suggest to add required module and
configuration method to setup options for Apache2 templates
and options for haproxy templates
#918
#919