use 0 as date/datetime zero value #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That sound correct. But I worry that will force people to handle this case in their code. What is the good usage of 0000-00-00? What others think about it? PS: it seem some tests still failed |
|
Looks good to me, just need to make sure this is not a patch-level release. And it's shown in the changelog. |
|
@xiezhenye can you fix the tests? I will merge it after that Thanks for the help |
|
MySQL 5.6 tests passed. MySQL 5.7 tests seems failed to start test instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return 0 as zero value of date/datetime to tell difference from NULL and '0000-00-00'.
e.g. insert/update a NOT NULL date column, only '0000-00-00' or 0 is valid.