Ensure that requests use the Authorization bearer header.#30
Open
wmealing wants to merge 1 commit intojulienXX:masterfrom
Open
Ensure that requests use the Authorization bearer header.#30wmealing wants to merge 1 commit intojulienXX:masterfrom
wmealing wants to merge 1 commit intojulienXX:masterfrom
Conversation
From my reading I do not believe this is optional anymore for authenicated requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my reading I believe that the slack API now requires the Token as part of the authentication bearer.
I have rectified this and snuck in a sneaky feature to get the slack token from the environment if it is not provided.
I can revert it to just use the provided token if this is unacceptable (or you can do it, too, i'm fine with that).
Without this the tests are not passing. The RTM start (which I beleive is deprecated) test is still failing on my machine, I have yet to investigate why.
=======================================================
Failed: 1. Skipped: 0. Passed: 4.
Thanks.