Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 23 23
Lines 2304 2304
=======================================
Hits 2109 2109
Misses 195 195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
So there are some issues to dig into. Allocations change depending on whether you run the test via Via Int: Test Failed at /Users/odow/git/jump-dev/MutableArithmetics/test/utilities.jl:12
Expression: measured_allocations <= expected_upper_bound
Evaluated: 2016 <= 0
Stacktrace:
[1] macro expansion
@ ~/.julia/juliaup/julia-nightly/Julia-1.14.app/Contents/Resources/julia/share/julia/stdlib/v1.14/Test/src/Test.jl:781 [inlined]
[2] alloc_test(f::var"#59#60"{Int64, Vector{Int64}}, expected_upper_bound::Int64)
@ Main ~/git/jump-dev/MutableArithmetics/test/utilities.jl:12
[3] top-level scope
@ ~/git/jump-dev/MutableArithmetics/test/broadcast.jl:11
[4] macro expansion
@ ~/.julia/juliaup/julia-nightly/Julia-1.14.app/Contents/Resources/julia/share/julia/stdlib/v1.14/Test/src/Test.jl:2243 [inlined]
[5] macro expansion
@ ~/git/jump-dev/MutableArithmetics/test/broadcast.jl:18 [inlined]
BigInt: Test Failed at /Users/odow/git/jump-dev/MutableArithmetics/test/utilities.jl:12
Expression: measured_allocations <= expected_upper_bound
Evaluated: 2304 <= 288
Stacktrace:
[1] macro expansion
@ ~/.julia/juliaup/julia-nightly/Julia-1.14.app/Contents/Resources/julia/share/julia/stdlib/v1.14/Test/src/Test.jl:781 [inlined]
[2] alloc_test(f::var"#65#66"{Int64, Vector{BigInt}}, expected_upper_bound::Int64)
@ Main ~/git/jump-dev/MutableArithmetics/test/utilities.jl:12
[3] macro expansion
@ ~/git/jump-dev/MutableArithmetics/test/broadcast.jl:35 [inlined]
[4] macro expansion
@ ~/.julia/juliaup/julia-nightly/Julia-1.14.app/Contents/Resources/julia/share/julia/stdlib/v1.14/Test/src/Test.jl:2243 [inlined]
[5] top-level scope
@ ~/git/jump-dev/MutableArithmetics/test/broadcast.jl:23
Test Summary: | Pass Fail Total Time
Broadcast | 17 2 19 1.9s
Int | 3 1 4 1.0s
BigInt | 5 1 6 0.1s
broadcast_issue_158 | 6 6 0.2s
promote_broadcast_for_new_style | 1 1 0.0s
broadcast_length_1_dimensions | 2 2 0.5s
RNG of the outermost testset: Random.Xoshiro(0xb2855bcd93b5b83a, 0xccd27ae002220586, 0x45bd09ee94270c72, 0xf1baf2241bd688bb, 0x11ca9d1341bcc423)
ERROR: LoadError: Some tests did not pass: 17 passed, 2 failed, 0 errored, 0 broken.
in expression starting at /Users/odow/git/jump-dev/MutableArithmetics/test/runtests.jl:36
ERROR: Package MutableArithmetics errored during testingVia the REPL: julia> include("test/broadcast.jl")
Test Summary: | Pass Total Time
Int | 4 4 0.0s
Test Summary: | Pass Total Time
BigInt | 6 6 0.0s
Test Summary: | Pass Total Time
broadcast_issue_158 | 6 6 0.0s
Test Summary: | Pass Total Time
promote_broadcast_for_new_style | 1 1 0.0s
Test Summary: | Pass Total Time
broadcast_length_1_dimensions | 2 2 0.0s
Test.DefaultTestSet("broadcast_length_1_dimensions", false, true, false, "/Users/odow/git/jump-dev/MutableArithmetics/test/broadcast.jl", 1.77499563349256e9, Random.Xoshiro(0x24f2e2bc1199ec05, 0x3f8314e51c169bb6, 0x81d0ecfde89aac06, 0x90759fb8e8351554, 0x5fc8206f4a56b091), 2, 1.774995633492598e9, 0x01, ReentrantLock(), Any[]) |
Member
Author
|
Merging and tagging because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.