Skip to content

Fix /(::Zero, ::AbstractMutable) #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Apr 1, 2026
+14 −2
Merged

Fix /(::Zero, ::AbstractMutable) #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/dispatch.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ Base.:+(x::AbstractMutable, ::Zero) = copy_if_mutable(x)
Base.:-(::Zero, x::AbstractMutable) = operate(-, x)
Base.:-(x::AbstractMutable, ::Zero) = copy_if_mutable(x)

function Base.:/(z::Zero, x::AbstractMutable)
if iszero(x)
throw(DivideError())
end
return z
end

function Base.sum(
a::AbstractArray{T};
dims = :,
Expand Down
3 changes: 1 addition & 2 deletions src/rewrite.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ Base.:*(z::Zero) = z
function Base.:/(z::Zero, x::Number)
if iszero(x)
throw(DivideError())
else
return z
end
return z
end

Base.iszero(::Zero) = true
Expand Down
6 changes: 6 additions & 0 deletions test/test_basics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,12 @@ function test_operate()
return
end

function test_op_divide()
@test MA.Zero() / DummyBigInt(1) == MA.Zero()
@test_throws DivideError MA.Zero() / DummyBigInt(0)
return
end

end # TestBasics

TestBasics.runtests()
Loading