test: make menubar imports safe in headless environments#349
Closed
lyonsno wants to merge 2 commits intojundot:mainfrom
Closed
test: make menubar imports safe in headless environments#349lyonsno wants to merge 2 commits intojundot:mainfrom
lyonsno wants to merge 2 commits intojundot:mainfrom
Conversation
65b4ef1 to
2e39d71
Compare
Owner
|
Closing this since #350 already includes all changes from this PR (import safety, conftest lazy imports, test_omlx_app_package_init.py). No need to merge both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR decouples packaging/omlx_app imports from the heavy omlx runtime so menubar-focused tests can run in headless/CI environments without initializing MLX/Metal during test collection.
Previously, importing omlx_app (or modules under it) could import omlx._version, which triggers omlx/init.py side effects and can abort when MLX initializes in non-GUI/headless contexts.
What Changed
importlib.util without importing omlx.
package-local safe loader.
Why
Behavioral Impact
Tests
Risk / Notes