Add note to README for zsh-vi-mode users.#46
Open
chevcast wants to merge 1 commit intojunegunn:mainfrom
Open
Conversation
chevcast
force-pushed
the
main
branch
3 times, most recently
from
b3a01bb to
eeb89f6
Compare
chevcast
commented
Jun 7, 2024
| eval "zvm_bindkey visual '^g^${o[1]}' fzf-git-$o-widget" | ||
| eval "zvm_bindkey visual '^g${o[1]}' fzf-git-$o-widget" | ||
| done | ||
| } |
junegunn
reviewed
Aug 24, 2024
| function zvm_after_init() { | ||
| zvm_bindkey viins "^P" up-line-or-beginning-search | ||
| zvm_bindkey viins "^N" down-line-or-beginning-search | ||
| for o in files branches tags remotes hashes stashes lreflogs each_ref; do |
Owner
There was a problem hiding this comment.
This is missing the recent addition of "worktrees". Whenever we add something, each user will have to update their configuration accordingly not to miss the update. How about providing a function instead so that the users don't have to manually update their code?
# Call _fzf_git_zvm_after_init from your zvm_after_init
function zvm_after_init() {
_fzf_git_zvm_after_init
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a note to the README showing how to make this work for users using zsh-vi-mode.
Resolves the concerns in issue #23