I hope i made the readme more clear.#70
Open
AmosNimos wants to merge 2 commits intojunegunn:masterfrom
Open
Conversation
I changed the part about the issue where Limelight is not be able to calculate the color, to make it clearer what we are suppose to do to fix the issue when it happen, avoiding the confusion of how do i "define it" where do i "define it" "which part of this code fix the issue ?" i tried to answer those question to the best of my ability, also making clear that the example are individual line example.
fixed a typo "clor" to "color", better a good explanation with typo then a bad explanation still.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make it easier to understand, by making it clear what are example and what is together and what is separate such as what is needed and not needed.