Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.development
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
JUNO_URL=http://localhost:5173
CONTAINER_URL=http://127.0.0.1:5987
CLI_PROJECT_NAME=juno-dev
3 changes: 2 additions & 1 deletion src/api/actor.api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {isNullish, nonNullish} from '@dfinity/utils';
import {type ActorParameters} from '@junobuild/admin';
import {red} from 'kleur';
import {getToken} from '../configs/cli.config';
import {ENV} from '../env';
import {getProcessToken} from '../utils/process.utils';
import {initAgent} from './agent.api';

Expand All @@ -20,7 +21,7 @@ export const actorParameters = async (): Promise<

const params: Omit<ActorParameters, 'agent'> = {
identity,
...(nonNullish(process.env.CONTAINER_URL) && {container: process.env.CONTAINER_URL})
...(nonNullish(ENV.containerUrl) && {container: ENV.containerUrl})
};

const agent = await initAgent(params);
Expand Down
6 changes: 4 additions & 2 deletions src/env.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {nextArg} from '@junobuild/cli-tools';
import type {JunoConfigEnv} from '@junobuild/config';

export type JunoCliEnv = JunoConfigEnv & {
containerUrl?: string;
containerUrl: string | undefined;
};

const loadEnv = (): JunoCliEnv => {
Expand All @@ -13,8 +13,10 @@ const loadEnv = (): JunoCliEnv => {

return {
mode: mode ?? 'production',
containerUrl: containerUrl ?? (mode === 'development' ? 'http://127.0.0.1:5987' : '')
containerUrl: containerUrl ?? (mode === 'development' ? 'http://127.0.0.1:5987' : undefined)
};
};

export const ENV = loadEnv();

export const DEV = ENV.mode === 'development';
3 changes: 2 additions & 1 deletion src/services/functions/upgrade/upgrade.cdn.services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {assertAnswerCtrlC, hasArgs, nextArg} from '@junobuild/cli-tools';
import {yellow} from 'kleur';
import prompts from 'prompts';
import {CDN_RELEASES_FULL_PATH} from '../../../constants/functions.constants';
import {ENV} from '../../../env';
import {type SatelliteParametersWithId} from '../../../types/satellite';
import {defaultSatelliteDomain} from '../../../utils/domain.utils';
import {logUpgradeResult} from '../../../utils/upgrade.utils';
Expand All @@ -29,7 +30,7 @@ export const upgradeWithCdn = async ({
const customHost = URL.parse(defaultSatelliteDomain(satellite.satelliteId))?.hostname;

const cdn = {
url: process.env.CONTAINER_URL ?? defaultSatelliteDomain(satellite.satelliteId),
url: ENV.containerUrl ?? defaultSatelliteDomain(satellite.satelliteId),
path: fullPath,
...(nonNullish(customHost) && {customHost})
};
Expand Down
6 changes: 4 additions & 2 deletions src/utils/domain.utils.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import {nonNullish} from '@dfinity/utils';
import {CONSOLE_SATELLITE_URL} from '../constants/constants';
import {DEV, ENV} from '../env';

export const defaultSatelliteDomain = (satelliteId: string): string => {
if (nonNullish(process.env.CONTAINER_URL)) {
return `http://${satelliteId}.${process.env.CONTAINER_URL.replace('http://127.0.0.1', 'localhost')}`;
if (DEV && nonNullish(ENV.containerUrl)) {
const url = URL.parse(ENV.containerUrl);
return `${url?.protocol ?? 'http:'}//${satelliteId}.${(url?.host ?? '127.0.0.1:5987').replace('127.0.0.1', 'localhost')}`;
}

return `https://${satelliteId}.icp0.io`;
Expand Down