Skip to content

feat: deprecate juno.dev.config #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 1 commit into from
Aug 2, 2025
Merged

feat: deprecate juno.dev.config #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 70 additions & 70 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@
"@dfinity/identity": "^2.3.0",
"@dfinity/principal": "^2.3.0",
"@dfinity/zod-schemas": "^1.0.0",
"@junobuild/admin": "^0.6.8-next-2025-08-02.2",
"@junobuild/cdn": "^0.2.1-next-2025-08-02",
"@junobuild/cli-tools": "^0.3.1-next-2025-08-02",
"@junobuild/config": "^0.4.3-next-2025-08-02",
"@junobuild/config-loader": "^0.3.1-next-2025-08-02",
"@junobuild/core": "^1.0.1-next-2025-08-02",
"@junobuild/did-tools": "^0.2.2-next-2025-08-02",
"@junobuild/storage": "^0.2.2-next-2025-08-02",
"@junobuild/utils": "^0.1.4-next-2025-08-02",
"@junobuild/admin": "^0.6.8-next-2025-08-02.3",
"@junobuild/cdn": "^0.2.1-next-2025-08-02.3",
"@junobuild/cli-tools": "^0.3.1-next-2025-08-02.3",
"@junobuild/config": "^0.4.3-next-2025-08-02.3",
"@junobuild/config-loader": "^0.3.1-next-2025-08-02.3",
"@junobuild/core": "^1.0.1-next-2025-08-02.3",
"@junobuild/did-tools": "^0.2.2-next-2025-08-02.3",
"@junobuild/storage": "^0.2.2-next-2025-08-02.3",
"@junobuild/utils": "^0.1.4-next-2025-08-02.3",
"chokidar": "^4.0.3",
"conf": "^14.0.0",
"open": "^10.2.0",
Expand All @@ -51,7 +51,7 @@
"devDependencies": {
"@eslint/eslintrc": "^3.3.1",
"@eslint/js": "^9.32.0",
"@junobuild/functions": "^0.2.4-next-2025-08-02",
"@junobuild/functions": "^0.2.4-next-2025-08-02.3",
"@types/node": "^22.15.27",
"@types/prompts": "^2.4.9",
"@types/semver": "^7.7.0",
Expand Down
10 changes: 2 additions & 8 deletions src/configs/emulator.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import {type EmulatorConfig, EmulatorConfigSchema} from '@junobuild/config';
import {red} from 'kleur';
import {DEPLOY_LOCAL_REPLICA_PATH} from '../constants/dev.constants';
import {EMULATOR_SATELLITE, EMULATOR_SKYLAB} from '../constants/emulator.constants';
import {EMULATOR_SKYLAB} from '../constants/emulator.constants';
import {ENV} from '../env';
import type {CliEmulatorConfig} from '../types/emulator';
import {readPackageJson} from '../utils/pkg.utils';
import {junoConfigExist, readJunoConfig} from './juno.config';
import {junoDevConfigExist} from './juno.dev.config';

export const readEmulatorConfig = async (): Promise<
| {
Expand Down Expand Up @@ -69,16 +68,11 @@ const readProjectName = async (): Promise<string | undefined> => {

const getEmulatorConfig = async (): Promise<EmulatorConfig> => {
const configExist = await junoConfigExist();
const devConfigExist = await junoDevConfigExist();

if (!configExist && !devConfigExist) {
if (!configExist) {
return {skylab: EMULATOR_SKYLAB};
}

if (!configExist && devConfigExist) {
return {satellite: EMULATOR_SATELLITE};
}

const config = await readJunoConfig(ENV);
return config.emulator ?? {skylab: EMULATOR_SKYLAB};
};
18 changes: 0 additions & 18 deletions src/configs/juno.dev.config.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/constants/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export const REDIRECT_URL = 'http://localhost:{port}';
export const JUNO_CONFIG_FILENAME = 'juno.config'; // .json | .js | .mjs | .cjs | .ts
export const JUNO_DEV_CONFIG_FILENAME = 'juno.dev.config'; // .json | .js | .mjs | .cjs | .ts
export const SATELLITE_WASM_NAME = 'satellite';
export const MISSION_CONTROL_WASM_NAME = 'mission_control';
export const ORBITER_WASM_NAME = 'orbiter';
Expand Down
Loading