fix: password question hided behind spinner on download snapshot#429
Merged
peterpeterparker merged 1 commit intomainfrom Nov 26, 2025
Merged
fix: password question hided behind spinner on download snapshot#429peterpeterparker merged 1 commit intomainfrom
peterpeterparker merged 1 commit intomainfrom
Conversation
Signed-off-by: David Dal Busco <david.dalbusco@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #425 which I did not detected when I tested the feature because I was testing locally (
--mode development) without encoded CLI config, without password (local emulator). Later, when I tried to download a snapshot for an Orbiter on prod, I couldn't because the CLI was requesting the pwd while a spinner is displayed and those disallow any keyboard interaction 🥲.