Skip to content

React context and refactoring #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

React context and refactoring #281

wants to merge 6 commits into from

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Sep 23, 2025 •
edited
Loading

This PR refactors the code to simplify development:

  • use a react context in the chat component, to avoid passing all the properties to child components
    Fixes Use a JupyterlabContext React context #172
  • avoid duplicating future new properties of options:
    • use the Chat.IOptions in the multichat panel
    • use the Chat.IOptions and ChatModel.IOptions in the widget and model factories

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/react_context

@brichet brichet added the maintenance Packaging, tests label Sep 23, 2025
@brichet brichet marked this pull request as ready for review September 24, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Packaging, tests
Projects
PR triage (experimental)
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a JupyterlabContext React context
1 participant
@brichet