Skip to content

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jul 9, 2025

This PR should fix #114.

It adds jest test, and uses the fact that "most" of the settings set an attribute in the chat model object.

Copy link
Collaborator Author

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the settings that are removed should probably be kept, but most of them are deprecated of duplicated ones.

If we go with that solution, we should probably except them.

"type": "string",
"description": "Anthropic API key"
},
"anthropicApiUrl": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"concurrency": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one.

"description": "Model name to use (e.g., gemini-pro, gemini-2.0-flash, etc.)",
"default": "gemini-pro"
},
"baseURL": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": ["string", "number"],
"default": "5m"
},
"stop": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be nice to keep it.
Short explanation about stop words (I didn't know what it was used for): https://datasciencedude.com/how-to-easily-get-stop-words-for-your-language-learning-model#heading-what-are-stop-words-and-why-are-they-important

"description": "The host URL of the Ollama server.",
"default": ""
},
"headers": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": "number",
"description": "An integer between 0 and 5 specifying the number of most likely tokens to return at each token position, each with an associated log probability. logprobs must be set to true if this parameter is used."
},
"prefixMessages": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a prefix to the prompt. Since we have a configurable prompt, I guess we should not need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a test on the providers settings

1 participant