Better format tool calls that need approval #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brichet
reviewed
Oct 15, 2025
src/chat-model.ts
Outdated
| * @param input The tool input to format (object or string) | ||
| * @returns Pretty-printed JSON string | ||
| */ | ||
| private _formatToolInput(input: string | object): string { |
There was a problem hiding this comment.
Good catch, let's try to clean that up in this PR too 👍
brichet
approved these changes
Oct 16, 2025
| } | ||
| } | ||
| // If it's an object, stringify it with formatting | ||
| return JSON.stringify(input, null, 2); |
There was a problem hiding this comment.
Are we sure that it is serializable, or should we try/except it ?
We use this function to format, for example, RunToolApprovalItem.rawItem, which contains at least one any type, according to the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the formatting of tool calls.
Single tool call
Multiple tool calls