Skip to content

Copy the keys to secrets manager when switching #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
Merged

Copy the keys to secrets manager when switching #201

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81d68c1
Copy the API key from settings to secrets manager when switching
brichet Oct 15, 2025
6866e84
Display the alert when the secrets manager is on
brichet Oct 15, 2025
a8569d7
Never populate the API key field with the setting value when using th…
brichet Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions src/widgets/ai-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,23 @@ const AISettingsComponent: React.FC<IAISettingsComponentProps> = ({
return secret?.value;
};

const setSecretToManager = async (
provider: string,
fieldName: string,
value: string
): Promise<void> => {
await secretsManager?.set(
Private.getToken(),
SECRETS_NAMESPACE,
`${provider}:${fieldName}`,
{
namespace: SECRETS_NAMESPACE,
id: `${provider}:${fieldName}`,
value
}
);
};

/**
* Attach a secrets field to the secrets manager.
* @param input - the DOm element to attach.
Expand Down Expand Up @@ -308,9 +325,7 @@ const AISettingsComponent: React.FC<IAISettingsComponentProps> = ({
// Retrieve the API key from the secrets manager if necessary.
if (model.config.useSecretsManager && secretsManager) {
provider.apiKey =
(await getSecretFromManager(provider.provider, 'apiKey')) ??
provider.apiKey ??
'';
(await getSecretFromManager(provider.provider, 'apiKey')) ?? '';
}
setEditingProvider(provider);
setDialogOpen(true);
Expand Down Expand Up @@ -354,6 +369,15 @@ const AISettingsComponent: React.FC<IAISettingsComponentProps> = ({
if (updates.useSecretsManager !== undefined) {
if (updates.useSecretsManager) {
for (const provider of model.config.providers) {
// if the secrets manager doesn't have the current API key, copy the current
// one from settings.
if (!(await getSecretFromManager(provider.provider, 'apiKey'))) {
setSecretToManager(
provider.provider,
'apiKey',
provider.apiKey ?? ''
);
}
provider.apiKey = SECRETS_REPLACEMENT;
await model.updateProvider(provider.id, provider);
}
Expand Down Expand Up @@ -719,7 +743,7 @@ const AISettingsComponent: React.FC<IAISettingsComponentProps> = ({
label={
<div>
<span>Use the secrets manager to manage API keys</span>
{!config.useSecretsManager && (
{config.useSecretsManager && (
<Alert severity="warning" icon={<Error />} sx={{ mb: 2 }}>
The secrets will be stored in plain text in settings
</Alert>
Expand Down
Loading