Skip to content

Prompting errors when it fails to load. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HassanAli66 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prompting errors when it fails to load. #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc364e5
[GUI] Prompting errors when it fails to load.
Oct 25, 2022
cf0461a
Title changed
HassanAli66 Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sic/asm/ErrorCatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,14 @@ public void printByRow(int row) {
System.err.println(err);
}

public void print() {
public String print() {
String allErrs="";
for ( ; lastPrinted < errs.size(); lastPrinted++) {
AsmError err = errs.get(lastPrinted);
System.err.println(err);
allErrs+=(err+"\n");
}
return allErrs;
}

public boolean shouldEnd() {
Expand Down
9 changes: 8 additions & 1 deletion src/sic/sim/MainView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,14 @@ public void loadAsm(File file) {
ErrorCatcher errorCatcher = assembler.errorCatcher;
Program program = assembler.assemble(Utils.readFile(file));
if (errorCatcher.count() > 0) {
errorCatcher.print();
String allErrs = errorCatcher.print();
JTextArea errArea = new JTextArea(allErrs);
JScrollPane scrollPane = new JScrollPane(errArea);
errArea.setLineWrap(true);
errArea.setWrapStyleWord(true);
scrollPane.setPreferredSize(new Dimension( 250, 250 ));
JOptionPane.showMessageDialog(mainFrame, scrollPane, "Error", JOptionPane.INFORMATION_MESSAGE);
updateView();
if (errorCatcher.shouldEnd()) {
return;
}
Expand Down