Modernizes, adds tests, fixes warning and add API key auth (Closes #4 and #5)#6
Open
zedtux wants to merge 6 commits intojuseveno:masterfrom
Open
Modernizes, adds tests, fixes warning and add API key auth (Closes #4 and #5)#6zedtux wants to merge 6 commits intojuseveno:masterfrom
zedtux wants to merge 6 commits intojuseveno:masterfrom
Conversation
This commit modernizes the gem, adds tests with Rspec, and implement the API key authentication.
Author
|
I just spotted an issue (data error) I'm going to quickly fixe. |
Author
|
The issue is gone, I received the SMS. |
Draft: Implements sub account, token and balance api call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks many parts of this gem in order to:
Rakefile, converts the README file to Markdow, adds Docker/Earthly, etc ...)nokogirias a dependency to thegemspecfilesmsmethod